From: António Fernandes <antoniojpfernandes@gmail.com>
Date: Sat, 4 Jun 2022 17:30:10 +0000 (+0000)
Subject: listbase: Don't start rubberband on ::drag-end
X-Git-Tag: archive/raspbian/4.8.3+ds-2+rpi1~3^2~81^2^2~123^2
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=dc4540fae98d4f707ce1030b0f8d161c987646e0;p=gtk4.git

listbase: Don't start rubberband on ::drag-end

GtkGestrureDrag::drag-end can be emitted when the pointer has just
crossed the drag threshold and we have not started the rubberband yet.
This happens if another gesture has claimed the event sequence earlier
in the current event propagation chain.

In such situation, our ::drag-end calls gtk_list_base_drag_update(),
which proceeds to start the rubberband. That's obviously wrong.
Additionally, it also tries to get modifiers from an event it we are
already denied,  which obviously fails with criticals:

`gdk_event_get_modifier_state: assertion 'GDK_IS_EVENT (event)' failed`

Thus, if there is no rubberband when we receive ::drag-end, do nothing.
---

diff --git a/gtk/gtklistbase.c b/gtk/gtklistbase.c
index bf0657a04f..7d1d44963c 100644
--- a/gtk/gtklistbase.c
+++ b/gtk/gtklistbase.c
@@ -1721,8 +1721,12 @@ gtk_list_base_drag_end (GtkGestureDrag *gesture,
                         double          offset_y,
                         GtkListBase    *self)
 {
+  GtkListBasePrivate *priv = gtk_list_base_get_instance_private (self);
   gboolean modify, extend;
 
+  if (!priv->rubberband)
+    return;
+
   gtk_list_base_drag_update (gesture, offset_x, offset_y, self);
   get_selection_modifiers (GTK_GESTURE (gesture), &modify, &extend);
   gtk_list_base_stop_rubberband (self, modify, extend);